revert: expect lint
Expect lint was causing issues with crates/docker builds, revert until fix is found
This commit is contained in:
@@ -468,7 +468,7 @@ impl ByteStats {
|
||||
}
|
||||
}
|
||||
|
||||
#[expect(clippy::cast_precision_loss)]
|
||||
#[allow(clippy::cast_precision_loss)]
|
||||
impl Stats for ByteStats {
|
||||
fn get_value(&self) -> f64 {
|
||||
self.0 as f64
|
||||
@@ -608,7 +608,7 @@ impl fmt::Display for ContainerItem {
|
||||
}
|
||||
|
||||
impl ContainerItem {
|
||||
#[expect(clippy::too_many_arguments)]
|
||||
#[allow(clippy::too_many_arguments)]
|
||||
/// Create a new container item
|
||||
pub fn new(
|
||||
created: u64,
|
||||
@@ -660,7 +660,7 @@ impl ContainerItem {
|
||||
}
|
||||
|
||||
/// Convert cpu stats into a vec for the charts function
|
||||
#[expect(clippy::cast_precision_loss)]
|
||||
#[allow(clippy::cast_precision_loss)]
|
||||
fn get_cpu_dataset(&self) -> Vec<(f64, f64)> {
|
||||
self.cpu_stats
|
||||
.iter()
|
||||
@@ -670,7 +670,7 @@ impl ContainerItem {
|
||||
}
|
||||
|
||||
/// Convert mem stats into a Vec for the charts function
|
||||
#[expect(clippy::cast_precision_loss)]
|
||||
#[allow(clippy::cast_precision_loss)]
|
||||
fn get_mem_dataset(&self) -> Vec<(f64, f64)> {
|
||||
self.mem_stats
|
||||
.iter()
|
||||
|
||||
+2
-2
@@ -151,7 +151,7 @@ impl AppData {
|
||||
}
|
||||
|
||||
/// Current time as unix timestamp
|
||||
#[expect(clippy::expect_used)]
|
||||
#[allow(clippy::expect_used)]
|
||||
fn get_systemtime() -> u64 {
|
||||
SystemTime::now()
|
||||
.duration_since(UNIX_EPOCH)
|
||||
@@ -933,7 +933,7 @@ impl AppData {
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
#[expect(clippy::unwrap_used)]
|
||||
#[allow(clippy::unwrap_used)]
|
||||
mod tests {
|
||||
|
||||
use super::*;
|
||||
|
||||
+1
-1
@@ -2,7 +2,7 @@ use crate::app_data::DockerControls;
|
||||
use std::fmt;
|
||||
|
||||
/// app errors to set in global state
|
||||
#[expect(unused)]
|
||||
#[allow(unused)]
|
||||
#[derive(Debug, Clone, Copy)]
|
||||
pub enum AppError {
|
||||
DockerCommand(DockerControls),
|
||||
|
||||
@@ -70,7 +70,7 @@ pub struct DockerData {
|
||||
|
||||
impl DockerData {
|
||||
/// Use docker stats to calculate current cpu usage
|
||||
#[expect(clippy::cast_precision_loss)]
|
||||
#[allow(clippy::cast_precision_loss)]
|
||||
// TODO FIX: this can overflow
|
||||
fn calculate_usage(stats: &Stats) -> f64 {
|
||||
let mut cpu_percentage = 0.0;
|
||||
@@ -349,7 +349,7 @@ impl DockerData {
|
||||
|
||||
/// Handle incoming messages, container controls & all container information update
|
||||
/// Spawn Docker commands off into own thread
|
||||
#[expect(clippy::too_many_lines)]
|
||||
#[allow(clippy::too_many_lines)]
|
||||
async fn message_handler(&mut self) {
|
||||
while let Some(message) = self.receiver.recv().await {
|
||||
let docker = Arc::clone(&self.docker);
|
||||
@@ -505,7 +505,7 @@ mod tests {
|
||||
|
||||
use super::*;
|
||||
|
||||
#[expect(clippy::too_many_lines)]
|
||||
#[allow(clippy::too_many_lines)]
|
||||
fn gen_stats(x: u64, y: u64) -> Stats {
|
||||
Stats {
|
||||
read: String::new(),
|
||||
@@ -623,7 +623,7 @@ mod tests {
|
||||
}
|
||||
|
||||
#[test]
|
||||
#[expect(clippy::float_cmp)]
|
||||
#[allow(clippy::float_cmp)]
|
||||
/// Test the stats calculator, had to cheat here to get round input/outputs
|
||||
fn test_calculate_usage_no_previous_cpu() {
|
||||
let stats = gen_stats(1_000_000_000, 900_000_000);
|
||||
|
||||
+1
-1
@@ -163,7 +163,7 @@ async fn main() {
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
#[expect(clippy::unwrap_used)]
|
||||
#[allow(clippy::unwrap_used)]
|
||||
mod tests {
|
||||
|
||||
use bollard::service::{ContainerSummary, Port};
|
||||
|
||||
+2
-2
@@ -6,7 +6,7 @@ use tracing::error;
|
||||
use crate::{ENV_KEY, ENV_VALUE};
|
||||
|
||||
#[derive(Parser, Debug, Clone)]
|
||||
#[expect(clippy::struct_excessive_bools)]
|
||||
#[allow(clippy::struct_excessive_bools)]
|
||||
#[command(version, about)]
|
||||
pub struct Args {
|
||||
/// Docker update interval in ms, minimum effectively 1000
|
||||
@@ -47,7 +47,7 @@ pub struct Args {
|
||||
}
|
||||
|
||||
#[derive(Debug, Clone)]
|
||||
#[expect(clippy::struct_excessive_bools)]
|
||||
#[allow(clippy::struct_excessive_bools)]
|
||||
pub struct CliArgs {
|
||||
pub color: bool,
|
||||
pub docker_interval: u32,
|
||||
|
||||
@@ -364,7 +364,7 @@ pub fn chart(f: &mut Frame, area: Rect, app_data: &Arc<Mutex<AppData>>) {
|
||||
.data(&mem.0)];
|
||||
|
||||
let cpu_stats = CpuStats::new(cpu.0.last().map_or(0.00, |f| f.1));
|
||||
#[expect(clippy::cast_possible_truncation, clippy::cast_sign_loss)]
|
||||
#[allow(clippy::cast_possible_truncation, clippy::cast_sign_loss)]
|
||||
let mem_stats = ByteStats::new(mem.0.last().map_or(0, |f| f.1 as u64));
|
||||
let cpu_chart = make_chart(cpu.2, "cpu", cpu_dataset, &cpu_stats, &cpu.1);
|
||||
let mem_chart = make_chart(mem.2, "memory", mem_dataset, &mem_stats, &mem.1);
|
||||
@@ -1065,7 +1065,7 @@ fn popup(text_lines: usize, text_width: usize, r: Rect, box_location: BoxLocatio
|
||||
}
|
||||
|
||||
#[cfg(test)]
|
||||
#[expect(clippy::unwrap_used)]
|
||||
#[allow(clippy::unwrap_used)]
|
||||
mod tests {
|
||||
|
||||
use std::{ops::RangeInclusive, sync::Arc};
|
||||
@@ -2110,7 +2110,7 @@ mod tests {
|
||||
// Charts panel //
|
||||
// ************ //
|
||||
|
||||
#[expect(clippy::cast_precision_loss)]
|
||||
#[allow(clippy::cast_precision_loss)]
|
||||
// Add fixed data to the cpu & mem vecdeques
|
||||
fn insert_chart_data(setup: &TuiTestSetup) {
|
||||
for i in 1..=10 {
|
||||
@@ -2834,7 +2834,7 @@ mod tests {
|
||||
// ********** //
|
||||
|
||||
#[test]
|
||||
#[expect(clippy::cognitive_complexity, clippy::too_many_lines)]
|
||||
#[allow(clippy::cognitive_complexity, clippy::too_many_lines)]
|
||||
/// Filter row is drawn correctly & colors are correct
|
||||
/// Colours change when filter_by option is changed
|
||||
fn test_draw_blocks_filter_row() {
|
||||
@@ -3372,7 +3372,7 @@ mod tests {
|
||||
}
|
||||
|
||||
#[test]
|
||||
#[expect(clippy::too_many_lines)]
|
||||
#[allow(clippy::too_many_lines)]
|
||||
/// Check that the whole layout is drawn correctly
|
||||
fn test_draw_blocks_whole_layout_with_filter() {
|
||||
let (w, h) = (160, 30);
|
||||
|
||||
+1
-1
@@ -58,7 +58,7 @@ pub enum DeleteButton {
|
||||
No,
|
||||
}
|
||||
|
||||
#[expect(unused)]
|
||||
#[allow(unused)]
|
||||
#[derive(Debug, Clone, Copy)]
|
||||
pub enum BoxLocation {
|
||||
TopLeft,
|
||||
|
||||
Reference in New Issue
Block a user