niko/oxkerclone
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Merge branch 'fix/unwraps' into dev

Browse Source
This commit is contained in:
Jack Wills
2022-05-30 02:05:01 +00:00
parent e497f3f2d9 78dca39a65
commit d8e22d7444
8 changed files with 114 additions and 101 deletions
Download Patch File Download Diff File Expand all files Collapse all files
CHANGELOG.md
+4 -1
View File
@@ -1,5 +1,8 @@
### Docs ### Docs
+ Readme one-liner to download & install latest version, [] + Readme one-liner to download & install latest version, [11d5ba361ee4c11d080f1c3c14d8bb677cbfd1fc]
### Fixes
+ Help panel typo, [e497f3f2d9e1dca99469860c2e728c99e29353ad]
# <a href='https://github.com/mrjackwills/oxker/releases/tag/v0.0.4'>v0.0.4</a> # <a href='https://github.com/mrjackwills/oxker/releases/tag/v0.0.4'>v0.0.4</a>
### 2022-05-08 ### 2022-05-08
README.md
+1 -1
View File
@@ -90,7 +90,7 @@ using docker-compose.yml;
or individually or individually
```docker run --name redis -d redis:alpine3.15``` ```docker run --name redis -d redis:alpine3.16```
```docker run --name postgres -e POSTGRES_PASSWORD=never_use_this_password_in_production -d postgres:alpine``` ```docker run --name postgres -e POSTGRES_PASSWORD=never_use_this_password_in_production -d postgres:alpine```
src/app_data/container_state.rs
+1
View File
@@ -160,6 +160,7 @@ impl DockerControls {
match state { match state {
State::Dead | State::Exited => vec![Self::Start, Self::Restart], State::Dead | State::Exited => vec![Self::Start, Self::Restart],
State::Paused => vec![Self::Unpause, Self::Stop], State::Paused => vec![Self::Unpause, Self::Stop],
State::Restarting => vec![Self::Stop],
State::Running => vec![Self::Pause, Self::Restart, Self::Stop], State::Running => vec![Self::Pause, Self::Restart, Self::Stop],
_ => vec![], _ => vec![],
} }
src/app_data/mod.rs
+10 -8
View File
@@ -99,9 +99,9 @@ impl AppData {
self.error = Some(error); self.error = Some(error);
} }
/// Find the if of the currently selected container /// Find the if of the currently selected container.
/// If any containers on system, will always return /// If any containers on system, will always return a string.
/// Only returns None when no containers found /// Only returns None when no containers found.
pub fn get_selected_container_id(&self) -> Option<String> { pub fn get_selected_container_id(&self) -> Option<String> {
let mut output = None; let mut output = None;
if let Some(index) = self.containers.state.selected() { if let Some(index) = self.containers.state.selected() {
@@ -296,7 +296,7 @@ impl AppData {
for (index, id) in all_ids.iter().enumerate() { for (index, id) in all_ids.iter().enumerate() {
if !containers if !containers
.iter() .iter()
.map(|i| i.id.as_ref().unwrap()) .filter_map(|i| i.id.as_ref())
.any(|x| x == id) .any(|x| x == id)
{ {
// If removed container is currently selected, then change selected to previous // If removed container is currently selected, then change selected to previous
@@ -310,7 +310,7 @@ impl AppData {
} }
for i in containers.iter() { for i in containers.iter() {
let id = i.id.as_ref().unwrap().to_owned(); if let Some(id) = i.id.as_ref() {
let mut name = i let mut name = i
.names .names
.as_ref() .as_ref()
@@ -332,7 +332,7 @@ impl AppData {
.trim() .trim()
.to_owned(); .to_owned();
let image = i.image.as_ref().unwrap_or(&"".to_owned()).trim().to_owned(); let image = i.image.as_ref().unwrap_or(&"".to_owned()).trim().to_owned();
if let Some(current_container) = self.get_container_by_id(&id) { if let Some(current_container) = self.get_container_by_id(id) {
if current_container.name != name { if current_container.name != name {
current_container.name = name current_container.name = name
}; };
@@ -355,12 +355,14 @@ impl AppData {
current_container.image = image current_container.image = image
}; };
} else { } else {
let mut container = ContainerItem::new(id, status, image, state, name); let mut container =
ContainerItem::new(id.to_owned(), status, image, state, name);
container.logs.end(); container.logs.end();
self.containers.items.push(container); self.containers.items.push(container);
} }
} }
} }
}
/// update logs of a given container, based on index not id /// update logs of a given container, based on index not id
pub fn update_log_by_index(&mut self, output: Vec<String>, index: usize) { pub fn update_log_by_index(&mut self, output: Vec<String>, index: usize) {
@@ -379,7 +381,7 @@ impl AppData {
container.logs.items.push(ListItem::new(lines)); container.logs.items.push(ListItem::new(lines));
}); });
if container.logs.state.selected().is_none() if container.logs.state.selected().is_none()
|| container.logs.state.selected().unwrap() + 1 == current_len || container.logs.state.selected().unwrap_or_default() + 1 == current_len
{ {
container.logs.end(); container.logs.end();
} }
src/docker_data/mod.rs
+16 -12
View File
@@ -34,8 +34,8 @@ impl DockerData {
if stats.cpu_stats.system_cpu_usage.is_some() if stats.cpu_stats.system_cpu_usage.is_some()
&& stats.precpu_stats.system_cpu_usage.is_some() && stats.precpu_stats.system_cpu_usage.is_some()
{ {
let system_delta = (stats.cpu_stats.system_cpu_usage.unwrap() let system_delta = (stats.cpu_stats.system_cpu_usage.unwrap_or(0)
- stats.precpu_stats.system_cpu_usage.unwrap()) - stats.precpu_stats.system_cpu_usage.unwrap_or(0))
as f64; as f64;
let online_cpus = stats.cpu_stats.online_cpus.unwrap_or_else(|| { let online_cpus = stats.cpu_stats.online_cpus.unwrap_or_else(|| {
stats stats
@@ -75,7 +75,7 @@ impl DockerData {
let mem_stat = stats.memory_stats.usage.unwrap_or(0); let mem_stat = stats.memory_stats.usage.unwrap_or(0);
let mem_limit = stats.memory_stats.limit.unwrap_or(0); let mem_limit = stats.memory_stats.limit.unwrap_or(0);
let key = if let Some(networks) = &stats.networks { let some_key = if let Some(networks) = &stats.networks {
networks.keys().next().map(|x| x.to_owned()) networks.keys().next().map(|x| x.to_owned())
} else { } else {
None None
@@ -83,12 +83,14 @@ impl DockerData {
let cpu_stats = Self::calculate_usage(&stats); let cpu_stats = Self::calculate_usage(&stats);
let (rx, tx) = if let Some(k) = key { let no_bytes = (0, 0);
let ii = stats.networks.unwrap(); let (rx, tx) = if let Some(key) = some_key {
let v = ii.get(&k).unwrap(); match stats.networks.unwrap_or_default().get(&key) {
(v.rx_bytes.to_owned(), v.tx_bytes.to_owned()) Some(data) => (data.rx_bytes.to_owned(), data.tx_bytes.to_owned()),
None => no_bytes,
}
} else { } else {
(0, 0) no_bytes
}; };
if is_running { if is_running {
@@ -131,7 +133,7 @@ impl DockerData {
..Default::default() ..Default::default()
})) }))
.await .await
.unwrap(); .unwrap_or_default();
let mut output = vec![]; let mut output = vec![];
// iter over containers, to only send ones which have an id, as use ID for extensivley! // iter over containers, to only send ones which have an id, as use ID for extensivley!
@@ -143,12 +145,14 @@ impl DockerData {
self.app_data.lock().update_containers(&output); self.app_data.lock().update_containers(&output);
output output
.iter() .iter()
.map(|i| { .filter_map(|i| {
i.id.as_ref().map(|id| {
( (
i.state.as_ref().unwrap() == "running", i.state.as_ref().unwrap_or(&String::new()) == "running",
i.id.as_ref().unwrap().to_owned(), id.to_owned(),
) )
}) })
})
.collect::<Vec<_>>() .collect::<Vec<_>>()
} }
src/input_handler/mod.rs
+17 -16
View File
@@ -99,11 +99,14 @@ impl InputHandler {
} }
}; };
let gui_state = Arc::clone(&self.gui_state); // If the info box sleep handle is currently being executed, as in m is pressed twice within a 4000ms window
// then cancel the first handle, as a new handle will be invoked
if self.info_sleep.is_some() { if let Some(info_sleep_timer) = self.info_sleep.as_ref() {
self.info_sleep.as_ref().unwrap().abort() info_sleep_timer.abort();
} }
let gui_state = Arc::clone(&self.gui_state);
// Show the info box - with "mouse capture enabled / disabled", for 4000 ms
self.info_sleep = Some(tokio::spawn(async move { self.info_sleep = Some(tokio::spawn(async move {
tokio::time::sleep(std::time::Duration::from_millis(4000)).await; tokio::time::sleep(std::time::Duration::from_millis(4000)).await;
gui_state.lock().reset_info_box() gui_state.lock().reset_info_box()
@@ -176,39 +179,37 @@ impl InputHandler {
// Does is matter though? // Does is matter though?
let panel = self.gui_state.lock().selected_panel; let panel = self.gui_state.lock().selected_panel;
if panel == SelectablePanel::Commands { if panel == SelectablePanel::Commands {
let command = self.app_data.lock().get_docker_command(); let option_command = self.app_data.lock().get_docker_command();
if command.is_some() { if let Some(command) = option_command {
let id = self.app_data.lock().get_selected_container_id(); let option_id = self.app_data.lock().get_selected_container_id();
if id.is_some() { if let Some(id) = option_id {
let id = id.unwrap(); match command {
match command.unwrap() {
// TODO handle theses errors?
DockerControls::Pause => self DockerControls::Pause => self
.docker_sender .docker_sender
.send(DockerMessage::Pause(id)) .send(DockerMessage::Pause(id))
.await .await
.unwrap(), .unwrap_or(()),
DockerControls::Unpause => self DockerControls::Unpause => self
.docker_sender .docker_sender
.send(DockerMessage::Unpause(id)) .send(DockerMessage::Unpause(id))
.await .await
.unwrap(), .unwrap_or(()),
DockerControls::Start => self DockerControls::Start => self
.docker_sender .docker_sender
.send(DockerMessage::Start(id)) .send(DockerMessage::Start(id))
.await .await
.unwrap(), .unwrap_or(()),
DockerControls::Stop => self DockerControls::Stop => self
.docker_sender .docker_sender
.send(DockerMessage::Stop(id)) .send(DockerMessage::Stop(id))
.await .await
.unwrap(), .unwrap_or(()),
DockerControls::Restart => self DockerControls::Restart => self
.docker_sender .docker_sender
.send(DockerMessage::Restart(id)) .send(DockerMessage::Restart(id))
.await .await
.unwrap(), .unwrap_or(()),
} }
} }
} }
src/ui/draw_blocks.rs
+2 -1
View File
@@ -460,7 +460,8 @@ pub fn draw_help_box<B: Backend>(f: &mut Frame<'_, B>) {
let description_text = format!("\n{}", DESCRIPTION); let description_text = format!("\n{}", DESCRIPTION);
let mut help_text = String::from("\n ( tab ) or ( alt+tab ) to change panels"); let mut help_text = String::from("\n ( tab ) or ( alt+tab ) to change panels");
help_text.push_str("\n ( ↑ ↓ ) or ( j k ) or (PgUp PgDown) or (Home End) to change selected line"); help_text
.push_str("\n ( ↑ ↓ ) or ( j k ) or (PgUp PgDown) or (Home End) to change selected line");
help_text.push_str("\n ( enter ) to send docker container commands"); help_text.push_str("\n ( enter ) to send docker container commands");
help_text.push_str("\n ( h ) to toggle this help information"); help_text.push_str("\n ( h ) to toggle this help information");
help_text.push_str( help_text.push_str(
src/ui/mod.rs
+6 -5
View File
@@ -58,13 +58,13 @@ pub async fn create_ui(
) )
.await; .await;
disable_raw_mode().unwrap(); disable_raw_mode().unwrap_or(());
execute!( execute!(
terminal.backend_mut(), terminal.backend_mut(),
LeaveAlternateScreen, LeaveAlternateScreen,
DisableMouseCapture DisableMouseCapture
)?; )?;
terminal.show_cursor().unwrap(); terminal.show_cursor().unwrap_or(());
if let Err(err) = res { if let Err(err) = res {
println!("{}", err); println!("{}", err);
@@ -105,8 +105,8 @@ async fn run_app<B: Backend>(
let mut now = Instant::now(); let mut now = Instant::now();
loop { loop {
terminal.draw(|f| ui(f, &app_data, &gui_state)).unwrap(); terminal.draw(|f| ui(f, &app_data, &gui_state)).unwrap();
if crossterm::event::poll(input_poll_rate).unwrap() { if crossterm::event::poll(input_poll_rate).unwrap_or_default() {
let event = event::read().unwrap(); if let Ok(event) = event::read() {
if let Event::Key(key) = event { if let Event::Key(key) = event {
sender sender
.send(InputMessages::ButtonPress(key.code)) .send(InputMessages::ButtonPress(key.code))
@@ -122,9 +122,10 @@ async fn run_app<B: Backend>(
terminal.autoresize().unwrap_or(()); terminal.autoresize().unwrap_or(());
} }
} }
}
if now.elapsed() >= update_duration { if now.elapsed() >= update_duration {
docker_sx.send(DockerMessage::Update).await.unwrap(); docker_sx.send(DockerMessage::Update).await.unwrap_or(());
now = Instant::now(); now = Instant::now();
} }