fix: left align headers,

Remove pointless match statements
This commit is contained in:
Jack Wills
2024-07-24 21:07:25 +00:00
parent 9e5cf68b8f
commit d472d074f6
+23 -48
View File
@@ -146,7 +146,7 @@ fn format_containers<'a>(i: &ContainerItem, widths: &Columns) -> Line<'a> {
Line::from(vec![ Line::from(vec![
Span::styled( Span::styled(
format!( format!(
"{:<width$}", "{:<width$}{MARGIN}",
i.name.to_string(), i.name.to_string(),
width = widths.name.1.into() width = widths.name.1.into()
), ),
@@ -154,7 +154,7 @@ fn format_containers<'a>(i: &ContainerItem, widths: &Columns) -> Line<'a> {
), ),
Span::styled( Span::styled(
format!( format!(
"{MARGIN}{:<width$}", "{:<width$}{MARGIN}",
i.state.to_string(), i.state.to_string(),
width = widths.state.1.into() width = widths.state.1.into()
), ),
@@ -162,7 +162,7 @@ fn format_containers<'a>(i: &ContainerItem, widths: &Columns) -> Line<'a> {
), ),
Span::styled( Span::styled(
format!( format!(
"{MARGIN}{:<width$}", "{:<width$}{MARGIN}",
i.status, i.status,
width = &widths.status.1.into() width = &widths.status.1.into()
), ),
@@ -170,8 +170,7 @@ fn format_containers<'a>(i: &ContainerItem, widths: &Columns) -> Line<'a> {
), ),
Span::styled( Span::styled(
format!( format!(
"{}{:>width$}", "{:>width$}{MARGIN}",
MARGIN,
i.cpu_stats.back().unwrap_or(&CpuStats::default()), i.cpu_stats.back().unwrap_or(&CpuStats::default()),
width = &widths.cpu.1.into() width = &widths.cpu.1.into()
), ),
@@ -179,7 +178,7 @@ fn format_containers<'a>(i: &ContainerItem, widths: &Columns) -> Line<'a> {
), ),
Span::styled( Span::styled(
format!( format!(
"{MARGIN}{:>width_current$} / {:>width_limit$}", "{:>width_current$} / {:>width_limit$}{MARGIN}",
i.mem_stats.back().unwrap_or(&ByteStats::default()), i.mem_stats.back().unwrap_or(&ByteStats::default()),
i.mem_limit, i.mem_limit,
width_current = &widths.mem.1.into(), width_current = &widths.mem.1.into(),
@@ -189,8 +188,7 @@ fn format_containers<'a>(i: &ContainerItem, widths: &Columns) -> Line<'a> {
), ),
Span::styled( Span::styled(
format!( format!(
"{}{:>width$}", "{:>width$}{MARGIN}",
MARGIN,
i.id.get_short(), i.id.get_short(),
width = &widths.id.1.into() width = &widths.id.1.into()
), ),
@@ -198,18 +196,18 @@ fn format_containers<'a>(i: &ContainerItem, widths: &Columns) -> Line<'a> {
), ),
Span::styled( Span::styled(
format!( format!(
"{MARGIN}{:<width$}", "{:<width$}{MARGIN}",
i.image.to_string(), i.image.to_string(),
width = widths.image.1.into() width = widths.image.1.into()
), ),
blue, blue,
), ),
Span::styled( Span::styled(
format!("{MARGIN}{:>width$}", i.rx, width = widths.net_rx.1.into()), format!("{:>width$}{MARGIN}", i.rx, width = widths.net_rx.1.into()),
Style::default().fg(Color::Rgb(255, 233, 193)), Style::default().fg(Color::Rgb(255, 233, 193)),
), ),
Span::styled( Span::styled(
format!("{MARGIN}{:>width$}", i.tx, width = widths.net_tx.1.into()), format!("{:>width$}{MARGIN}", i.tx, width = widths.net_tx.1.into()),
Style::default().fg(Color::Rgb(205, 140, 140)), Style::default().fg(Color::Rgb(205, 140, 140)),
), ),
]) ])
@@ -430,54 +428,31 @@ pub fn heading_bar(
// Generate a block for the header, if the header is currently being used to sort a column, then highlight it white // Generate a block for the header, if the header is currently being used to sort a column, then highlight it white
let header_block = |x: &Header| { let header_block = |x: &Header| {
let mut color = Color::Black; let mut color = Color::Black;
let mut prefix = ""; let mut suffix = "";
let mut prefix_margin = 0;
if let Some((a, b)) = &data.sorted_by { if let Some((a, b)) = &data.sorted_by {
if x == a { if x == a {
match b { match b {
SortedOrder::Asc => prefix = " ", SortedOrder::Asc => suffix = " ",
SortedOrder::Desc => prefix = " ", SortedOrder::Desc => suffix = " ",
} }
prefix_margin = 2; color = Color::Gray;
color = Color::White;
}; };
}; };
(
Block::default().style(Style::default().bg(Color::Magenta).fg(color)), (Block::default().style(Style::default().fg(color)), suffix)
prefix,
prefix_margin,
)
}; };
// Generate block for the headers, state and status has a specific layout, others all equal // Generate block for the headers, state and status has a specific layout, others all equal
// width is dependant on it that column is selected to sort - or not // width is dependant on it that column is selected to sort - or not
let gen_header = |header: &Header, width: usize| { let gen_header = |header: &Header, width: usize| {
let block = header_block(header); let block = header_block(header);
// Yes this is a mess, needs documenting correctly // Yes this is a mess, needs documenting correctly
let text = match header {
Header::State => format!( let text = format!(
" {x:>width$}", "{x:<width$}{MARGIN}",
x = format!("{ic}{header}", ic = block.1), x = format!("{header}{ic}", ic = block.1),
width = width );
),
Header::Name => format!(
" {x:>width$}",
x = format!("{ic}{header}", ic = block.1),
width = width
),
Header::Status => format!(
"{} {x:>width$}",
MARGIN,
x = format!("{ic}{header}", ic = block.1),
width = width
),
_ => format!(
"{}{x:>width$}",
MARGIN,
x = format!("{ic}{header}", ic = block.1),
width = width
),
};
let count = u16::try_from(text.chars().count()).unwrap_or_default(); let count = u16::try_from(text.chars().count()).unwrap_or_default();
let status = Paragraph::new(text) let status = Paragraph::new(text)
.block(block.0) .block(block.0)
@@ -508,7 +483,7 @@ pub fn heading_bar(
let column_width = if column_width > 0 { column_width } else { 1 }; let column_width = if column_width > 0 { column_width } else { 1 };
let splits = if data.has_containers { let splits = if data.has_containers {
vec![ vec![
Constraint::Max(2), Constraint::Max(4),
Constraint::Min(column_width.try_into().unwrap_or_default()), Constraint::Min(column_width.try_into().unwrap_or_default()),
Constraint::Max(info_width.try_into().unwrap_or_default()), Constraint::Max(info_width.try_into().unwrap_or_default()),
] ]
@@ -541,7 +516,7 @@ pub fn heading_bar(
.collect::<Vec<_>>(); .collect::<Vec<_>>();
// Draw loading icon, or not, and a prefix with a single space // Draw loading icon, or not, and a prefix with a single space
let loading_paragraph = Paragraph::new(format!("{:>2}", data.loading_icon)) let loading_paragraph = Paragraph::new(format!(" {:<3}", data.loading_icon))
.block(block(Color::White)) .block(block(Color::White))
.alignment(Alignment::Center); .alignment(Alignment::Center);
frame.render_widget(loading_paragraph, split_bar[0]); frame.render_widget(loading_paragraph, split_bar[0]);