From aafe89d0eb1059c4721aabdb73b76af0d0bcce14 Mon Sep 17 00:00:00 2001 From: Jack Wills <32690432+mrjackwills@users.noreply.github.com> Date: Thu, 16 Nov 2023 11:40:01 +0000 Subject: [PATCH] docs: changelog --- CHANGELOG.md | 5 +++++ src/main.rs | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index df2c738..9a8d46c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,11 @@ ### Features + Docker exec mode, closes #28, [c8077bca0b673478cfbb417e677a885136ba9eff] +You are now able to attempt to exec into a container by pressing the `e` key. This just pipes `docker exec -it [id] sh` into the oxker view. +As such, the DockerImage now needs docker installed, so the runtime step has switched from scratch to Alpine. Using a multistage build has reduced the size, but the docker image +has now grown from ~1.5mb to ~11.5mb. It is possible to use the Rust [bollard](https://github.com/fussybeaver/bollard) library to enable this functionality in *pure* Rust, +but so far there are multiple issues with this approach - see the feat/tty branch for the current attempt. + ### Fixes + `as_ref()` fixed, #31 merged, thanks [Daniel-Boll](https://github.com/Daniel-Boll), [0e06c9c172629dc7f7e7766f5372da9466e786d8] diff --git a/src/main.rs b/src/main.rs index b2387cb..13cf23d 100644 --- a/src/main.rs +++ b/src/main.rs @@ -144,7 +144,7 @@ async fn main() { Ui::create(app_data, gui_state, is_running, input_sx).await; } else { info!("in debug mode\n"); - // Debug mode for testing, less pointless now, will diplay some basic information + // Debug mode for testing, less pointless now, will display some basic information while is_running.load(Ordering::SeqCst) { loop { if let Some(err) = app_data.lock().get_error() {