From 12b5cfce6ce46a9225f00121a905245759fa2244 Mon Sep 17 00:00:00 2001 From: Jack Wills <32690432+mrjackwills@users.noreply.github.com> Date: Fri, 29 Apr 2022 01:16:26 +0000 Subject: [PATCH] fix: make sure popup blank sapce can't be negative --- src/ui/draw_blocks.rs | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/ui/draw_blocks.rs b/src/ui/draw_blocks.rs index 362735e..e55f3a0 100644 --- a/src/ui/draw_blocks.rs +++ b/src/ui/draw_blocks.rs @@ -633,20 +633,17 @@ pub fn draw_info(f: &mut Frame<'_, B>, text: String) { /// draw a box in the center of the screen, based on max line width + number of lines fn draw_popup(text_lines: u16, text_width: u16, r: Rect, box_location: BoxLocation) -> Rect { - // This can panic if number_lines or max_line_width is larger than r.height or r.width - - + // Make sure blank_space can't be an negative, as will crash let blank_vertical = if r.height > text_lines { (r.height - text_lines) / 2 } else { - r.height / 2 + 1 }; let blank_horizontal = if r.width > text_width { (r.width - text_width) / 2 }else { - r.width / 2 - + 1 }; let vertical_constraints = box_location.get_vertical_constraints(blank_vertical, text_lines);